Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plot_sector_ratio] Generate sector ratio plot as subplot #309

Closed
BiancaMorandi opened this issue Dec 7, 2021 · 5 comments
Closed

[plot_sector_ratio] Generate sector ratio plot as subplot #309

BiancaMorandi opened this issue Dec 7, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@BiancaMorandi
Copy link
Contributor

At the moment in the template notebook we plot the sector ratio only for the main spd and direction (the top one usually) but in this way we don't capture eventual booms/ mast twists as we don't look at other wind vanes. Need to change the plot_sector_ratio function to generate subplots.

@BiancaMorandi BiancaMorandi added the enhancement New feature or request label Dec 7, 2021
@BiancaMorandi BiancaMorandi self-assigned this Dec 7, 2021
@rach185 rach185 self-assigned this Dec 15, 2021
rach185 added a commit that referenced this issue Jan 6, 2022
@rach185 rach185 added this to To do in brightwind kanban Jan 6, 2022
@rach185 rach185 moved this from To do to In progress in brightwind kanban Jan 6, 2022
rach185 added a commit that referenced this issue Jan 6, 2022
rach185 added a commit that referenced this issue Jan 10, 2022
@BiancaMorandi BiancaMorandi removed their assignment Jan 17, 2022
BiancaMorandi added a commit that referenced this issue Mar 18, 2022
@stephenholleran
Copy link
Collaborator

@BiancaMorandi wrote:

we should allow to have multiple boom_dir_1 and boom_dir_2. As sensors at different heights can be mounted on booms with different orientation. Do you think that it would be easy to fix this?

@rach185 wrote:

in analyse.sector_ratio

  • Accept int or list of ints as input params

  • if list: check len is equal to len wspd_1 (and wspd_2)

  • Update doc string

  • Add example

in plot.plot_sector_ratio

  • if list: check len is equal to something sensible in sec_ratio input

  • add a boom counter to iterate through if list: boom_count = 0

  • for pair in sec_ratio: if boom_dir is a list, take first element in list boom_dir[0], continue through loop then increment boom_counter += 1 befor next itt. If boom_dir is an int then change nothing

  • Update doc string

What would calling the function look like for this scenario?

rach185 added a commit that referenced this issue May 16, 2022
BiancaMorandi added a commit that referenced this issue May 24, 2022
@BiancaMorandi BiancaMorandi moved this from In progress to Awaiting Approval in brightwind kanban May 24, 2022
rach185 added a commit that referenced this issue May 31, 2022
…sector_ratio, _plot_sector_ratio_subplot
BiancaMorandi added a commit that referenced this issue Jun 3, 2022
@BiancaMorandi
Copy link
Contributor Author

@rach185 can you please add few examples in the doc string of _plot_sector_ratio_subplot function?

@stephenholleran
Copy link
Collaborator

Hi @rach185,

There is a bit of inconsistency if the user wishes to return the data. In the doc string, and in other functions, the data is returned as a Dataframe. However with this, if more than one pair of anemometers is sent, a Dict is returned. I think this makes it more difficult for a user to use the returned data. Why not add a column to the Dataframe with the new distribution pair?

Thanks

cc @BiancaMorandi

rach185 added a commit that referenced this issue Jul 12, 2022
stephenholleran added a commit that referenced this issue Jul 12, 2022
stephenholleran added a commit that referenced this issue Jul 12, 2022
@stephenholleran
Copy link
Collaborator

@rach185 I did a little refactoring in commit 2166427 on the return data piece.
Let me know that you are ok with this?

@rach185
Copy link
Contributor

rach185 commented Jul 13, 2022

@stephenholleran
Yes, that's much more concise. Thanks

@stephenholleran stephenholleran moved this from Awaiting Approval to Done in brightwind kanban Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants