New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[freq_table] Use coverage threshold input also for basic method #386
Comments
…on_coverage_threshold function common to momm
…hreshold text in order to work for both momm and freq table functions
When var_series and direction_series coverage is not the same as for example below, the monthly coverage used for filtering was based only on the var_series and not direction_series. This bug has been fixed now and the minimum coverage between var_series and direction_series is now used.
|
As discussed in #298 we want to be able to filter out months based on data coverage not only when applying a seasonal adjustment (as done for #334 ) but also when using the basic method. Note that this must not be a breaking change, so default coverage threshold should be set to a value that for basic method will give same results as current method.
As part of this issue we should also update
freq_table
to use a standard function for checking coverage and raising warnings or errors describing method used for filtering months based on coverage. This function was already generated as part of #298 .The text was updated successfully, but these errors were encountered: