Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freq_table] Use coverage threshold input also for basic method #386

Closed
BiancaMorandi opened this issue Mar 27, 2023 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@BiancaMorandi
Copy link
Contributor

As discussed in #298 we want to be able to filter out months based on data coverage not only when applying a seasonal adjustment (as done for #334 ) but also when using the basic method. Note that this must not be a breaking change, so default coverage threshold should be set to a value that for basic method will give same results as current method.

As part of this issue we should also update freq_table to use a standard function for checking coverage and raising warnings or errors describing method used for filtering months based on coverage. This function was already generated as part of #298 .

@BiancaMorandi BiancaMorandi added the enhancement New feature or request label Mar 27, 2023
@BiancaMorandi BiancaMorandi self-assigned this Mar 27, 2023
@BiancaMorandi BiancaMorandi moved this from To do to In progress in brightwind kanban May 18, 2023
BiancaMorandi added a commit that referenced this issue May 18, 2023
BiancaMorandi added a commit that referenced this issue May 19, 2023
…on_coverage_threshold function common to momm
BiancaMorandi added a commit that referenced this issue May 19, 2023
…hreshold text in order to work for both momm and freq table functions
@BiancaMorandi
Copy link
Contributor Author

When var_series and direction_series coverage is not the same as for example below, the monthly coverage used for filtering was based only on the var_series and not direction_series. This bug has been fixed now and the minimum coverage between var_series and direction_series is now used.

graph, result_seas = bw.freq_table(var_series, direction_series['2017-07-01':'2017-08-01'], seasonal_adjustment=True, return_data=True)

BiancaMorandi added a commit that referenced this issue May 22, 2023
BiancaMorandi added a commit that referenced this issue May 22, 2023
BiancaMorandi added a commit that referenced this issue May 22, 2023
BiancaMorandi added a commit that referenced this issue May 22, 2023
BiancaMorandi added a commit that referenced this issue May 22, 2023
@BiancaMorandi BiancaMorandi moved this from In progress to Awaiting Approval in brightwind kanban May 22, 2023
@stephenholleran stephenholleran moved this from Awaiting Approval to Done in brightwind kanban May 31, 2023
BiancaMorandi added a commit that referenced this issue May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants