Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precipitation at 0 for Tempest, even when rain has accumulated that day #8

Open
beaulebens opened this issue Jun 22, 2020 · 0 comments · May be fixed by #10
Open

Precipitation at 0 for Tempest, even when rain has accumulated that day #8

beaulebens opened this issue Jun 22, 2020 · 0 comments · May be fixed by #10

Comments

@beaulebens
Copy link

I was watching the data on this integration in HA today while it was raining, and while the precipitation_rate value does appear to be changing, and passing through to HA, as far as I can tell, rain accumulation is coming through as 0 for Tempest (obs_st), even when there is rain accumulation for the day (actively falling).

I think somewhere around here https://github.com/briis/pysmartweatherudp/blob/master/pysmartweatherudp/receiver.py#L209 you need a self.precipitation value to be set.
beaulebens pushed a commit to beaulebens/pysmartweatherudp that referenced this issue Aug 2, 2020
Untested: Fix Precipitation collection for Tempest devices
fd77601 
**UNTESTED**
I'm unable to test this due to my configuration, so I'm making this more as a nudge that hopefully someone can try it out and confirm. I've just copied the way that precipitation is handled from the `obs_sky` (AIR) format, which looks like it should hopefully work for the Tempest as well.

If this works, then it fixes briis#8
@beaulebens beaulebens linked a pull request Aug 2, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Untested: Fix Precipitation collection for Tempest devices beaulebens/pysmartweatherudp
1 participant
@beaulebens