added scrapping layer with tests #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13
Note that tests do work, however, it some times fail as we get timeouts and the scrapper hangs sometimes. so every once in a while the tests fail.
Sometimes youtube gives us an infinite loading spinner when we try to download dynamic content from a playlist and we don't detect that loading spinner (it's html class is circle and id is spinner-id as of today) and this causes us to exit the playlist prematurely and not scrape the remaining of the videos.
run ` python3 tests/functionality_testing/Scrapper_test.py -k "test_get_playlist_info" which passed normally, but fails when the issue happens (or a user updates their number of videos 😄 )