Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telefunc:packageJsonFile conflicts with vite-plugin-ssr:packageJsonFile #33

Closed
magne4000 opened this issue Jul 29, 2022 · 2 comments
Closed

Comments

@magne4000
Copy link
Contributor

vps supports { "type": "module" } syntax, but telefunc does not yet. My issue is that telefunc generates package.json first, then vps, but vite warns me that it's already generated so it's skipped. Result: my package.json content is { "type": "commonjs" }, which is wrong.

Workaround

// Remove telefunc plugin for `package.json` file generation
const tel = telefunc().filter((p) => p.name !== 'telefunc:packageJsonFile');

Discussion

Easy fix would be to copy code from vps, but it's not really easy to maintain. Should we create a new repo under this organization to handle those common plugins?

@brillout
Copy link
Owner

I believe it's easily fixable (on Telefunc's side). I'll have a look at this tomorrow.

@brillout
Copy link
Owner

I agree about the duplicated code thing, I've a plan for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants