-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard interaction and ARIA roles #9
Comments
Thank you for your kindly worded suggestion.I plan to work on this very soon. This also came up on hacker news. |
If you're looking for prior art which might be helpful, React-Aria has some examples of hook-based aria implementations. Even when just used as implementation guides, it's been useful for me. |
Definitely +1 for this. I haven't found a tree component which would support all the use-cases you have. The a11y is the only missing thing for me. Then I can remove this from my should-do-in-the-future OSS list. Here is the really good writeup how the tree should behave and what roles it should have: https://www.w3.org/TR/wai-aria-practices-1.1/#TreeView |
Thanks @Pustelto! I'll reference that as I work on it. |
Here's a todo list for this issue: Keyboard Events
Multi Selection
ARIA Roles |
Keyboard navigation Aria Roles fixes (fixes #9) Smart "scrollTo" behavior Automatically sync selection Tree filtering now handled by arborist Moves "openness" state into the tree with an "initialOpens" prop Simple NodeApi class for use in the node renderer Ability to specify the drag handler (fixes #38) Splits the NodeRenderer into a RowRenderer and a NodeRenderer with defaults resulting in less boilerplate. (fixes #8) Adds an onActivate callback Adds an onSelect callback (fixes #44) Adds an onCreate callback Adds an onDelete callback Adds an onScroll callback (fixes #30) Improved abstractions for focus, selection, and activation (fixes #1, fixes #6) Fixes the bug where you can drag a parent into itself (fixes #41) fixes #46
I saw your post on reddit. Nice tree control.
I wanted to give a suggestion that could help take it to the next level. Right now it is very mouse oriented. However, not everyone may prefer to use the mouse. If you look up the the tree role on MDN it documents keyboard interactions for a tree. That way users can operate it without taking their hands off the keyboard if they prefer (similar to Ctrl-C Ctrl-V for copy and paste).
The text was updated successfully, but these errors were encountered: