unescape space path name (#415)

* unescape space path name

Signed-off-by: Mason Fish <mason@looky.cloud>

* adjust router config instead

Signed-off-by: Mason Fish <mason@looky.cloud>

Co-authored-by: Mason Fish <mason@looky.cloud>

zqd/handlers_test.go

@@ -8,6 +8,7 @@ import (
 	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
+	"net/url"
 	"os"
 	"path/filepath"
 	"strings"
@@ -182,6 +183,22 @@ func TestSpaceDelete(t *testing.T) {
 	})
 }
 
+func TestURLEncodingSupport(t *testing.T) {
+	c := newCore(t)
+	defer os.RemoveAll(c.Root)
+
+	rawSpace := "raw %<>space.brim"
+	encodedSpaceURL := fmt.Sprintf("http://localhost:9867/space/%s", url.PathEscape(rawSpace))
+
+	createSpace(t, c, rawSpace, "")
+
+	res := httpRequest(t, zqd.NewHandler(c), "GET", encodedSpaceURL, nil)
+	require.Equal(t, http.StatusOK, res.StatusCode)
+
+	res = httpRequest(t, zqd.NewHandler(c), "DELETE", encodedSpaceURL, nil)
+	require.Equal(t, http.StatusNoContent, res.StatusCode)
+}
+
 func TestNoEndSlashSupport(t *testing.T) {
 	c := newCore(t)
 	defer os.RemoveAll(c.Root)

zqd/server.go

@@ -35,7 +35,6 @@ var Version VersionMessage
 
 func NewHandler(root *Core) http.Handler {
 	r := mux.NewRouter()
-	r = r.UseEncodedPath()
 	r.Handle("/space", wrapRoot(root, handleSpaceList)).Methods("GET")
 	r.Handle("/space", wrapRoot(root, handleSpacePost)).Methods("POST")
 	r.Handle("/space/{space}", wrapRoot(root, handleSpaceGet)).Methods("GET")