New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework user ops #4663
Rework user ops #4663
Conversation
FWIW, I tested out this branch at commit 6fb851c and confirmed it seems to address what's described in #4650. That is, since we're no longer using spread to pass
|
It looks like #4658 is addressed as well. I can now pass in a dotted reference to a nested field or use field referencing with indexing and then reference the field ok from inside the user op.
|
124fe79
to
a7e7693
Compare
Rework user ops in the following ways: - User ops take either a const or path as an argument. - The this value of the parent is carried through when a user op is invoked.
a7e7693
to
ad08b11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stuff in runtime/op/scope.go is now unused, so you can remove that.
8397c8d
to
21a7b7d
Compare
21a7b7d
to
bef2956
Compare
Co-authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
Rework user ops in the following ways:
Fixes #4650
Fixes #4658
Fixes #4653