Add an "Error Handling" section to Shaping docs #4686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwt
reviewed
Jun 29, 2023
Co-authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
nwt
approved these changes
Jun 29, 2023
Co-authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
Co-authored-by: Noah Treuhaft <noah.treuhaft@gmail.com>
This was referenced Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently spent some quality time with Zed's shaping features and found I was pretty happy with how things have improved. In particular the improvements in error handling (such as highlighted in the recent blog post from @jameskerr) definitely help plug some remaining UX gaps. To that end, I went back through some old issues to see if it's appropriate to close some, and #2776 definitely looked like fair game. However, I figured it's worthwhile to augment the docs with some examples that show how to catch shaping errors, hence this PR.
Fixes #2776
Fixes #2331