Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection names #1157

Merged
merged 4 commits into from
Oct 21, 2020
Merged

Connection names #1157

merged 4 commits into from
Oct 21, 2020

Conversation

mason-fish
Copy link
Contributor

fixes #1085

builds off #1150

Adds names to connections, and displays that value instead of id.

image

image

image

@mason-fish mason-fish requested a review from a team October 19, 2020 22:41
Signed-off-by: Mason Fish <mason@looky.cloud>
Mason Fish added 2 commits October 21, 2020 11:00
Signed-off-by: Mason Fish <mason@looky.cloud>
Signed-off-by: Mason Fish <mason@looky.cloud>
Copy link
Member

@jameskerr jameskerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only request is to add a margin-bottom: 12px to the InputField. Or transform it into a styled component with a margin-bottom: 12px.

cli.outputHelp()
process.exit(1);
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tight!

Signed-off-by: Mason Fish <mason@looky.cloud>
@mason-fish mason-fish merged commit 7287c57 into master Oct 21, 2020
@mason-fish mason-fish deleted the 1085-connection_names branch October 21, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add and use name field for connections
2 participants