Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When digging into the root cause of #2839, we could see in the output of
yarn install --inline-builds
that this line in the Zed Makefile was failing due to the tmp dir for the Zed repo checkout not having a.git
directory. The changes in the move to Monorepo in #2818 ended up causing this problem because the Yarn plugins (such as the "plugin-github" one) have since only been present belowapps/zui/.yarn
but are actually needed in the top-level.yarn
directory since (as @jameskerr educated me) that's where the Yarn workspace is defined.In addition to fixing the
zed -version
problem (#2839) this also addresses the equivalentbrimcap -version
problem that was mentioned in brimdata/brimcap#316 as waiting in line behind #2840. With the changes in this PR, after runningyarn
, we now see correct version strings.Since I had to locally confirm that all the Zui tests run ok after these changes, I went ahead and advanced the dependency pointers for both Zed and Brimcap as part of this PR. For the Brimcap case, since I also need the fix in brimdata/brimcap#316, right now I'm pointing at the commit for that fix branch. Assuming brimdata/brimcap#316 gets approved and merged first, I'll then advance the Brimcap pointer in this PR to the new tip of Brimcap's
main
.Fixes #2839