Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use extract-unzip to unzip zdeps #525

Merged
merged 1 commit into from
Mar 31, 2020
Merged

use extract-unzip to unzip zdeps #525

merged 1 commit into from
Mar 31, 2020

Conversation

alfred-landrum
Copy link
Contributor

This avoids depending on unzip being available.

@alfred-landrum alfred-landrum requested a review from a team March 31, 2020 15:12
@alfred-landrum
use extract-unzip to unzip zdeps
5ed685d 
This avoids depending on unzip being available.
mikesbrown
mikesbrown approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@mikesbrown mikesbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually made sure I could ingest a pcap after building and installing a windows executable.

@alfred-landrum alfred-landrum merged commit b477df1 into master Mar 31, 2020
@alfred-landrum alfred-landrum deleted the extract-unzip branch March 31, 2020 16:34
@philrz philrz mentioned this pull request Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesbrown mikesbrown mikesbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alfred-landrum @mikesbrown