Render html menus in integration tests #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskerr
commented
May 5, 2020
mikesbrown
approved these changes
May 5, 2020
* feat: locators etc. for html context menu * fix: correct method * feat: one contextMenu test to demo feature
jameskerr
force-pushed
the
right-click-experiment
branch
from
dbbfdd5
to
05e4bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intercept the call to create the rightclick menu right before it gets sent to electron. Then we dispatch our own event to the dom, then build a simple html context menu that will only be used when
process.env.BRIM_ITEST === "true".To test this locally, start the app normally, then open the console and type in the following:
Now the app will respond to right clicks by building an html version of the context menus.
@mikesbrown this should make those integration tests much easier to write.