841 remove blank record flash #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 6, 2020 08:02
Signed-off-by: Mason Fish <mason@looky.cloud>
Signed-off-by: Mason Fish <mason@looky.cloud>
Signed-off-by: Mason Fish <mason@looky.cloud>
jameskerr
requested changes
Aug 6, 2020
src/js/flows/submitSearch.js
Outdated
| return !( | ||
| args.tableProgram === prev.tableProgram && | ||
| args.spaceId === prev.spaceId && | ||
| duration(args.span) === duration(prev.span) |
There was a problem hiding this comment.
Will you also add an if this space is ingesting check. I think if the space is not ingesting and I hit "enter", I'd want to see it clear and re-populate. What do you think?
added 3 commits
August 7, 2020 16:06
Signed-off-by: Mason Fish <mason@looky.cloud>
Signed-off-by: Mason Fish <mason@looky.cloud>
Signed-off-by: Mason Fish <mason@looky.cloud>
jameskerr
approved these changes
Aug 10, 2020
| @@ -4,3 +4,4 @@ | |||
| /coverage | |||
| /releases | |||
| /zealot | |||
| /run | |||
There was a problem hiding this comment.
Same thing was happening in one of my branches. Glad you found it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #841
Don't update the table unless a different search has been submitted