Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor playState when set in initial props #2

Closed
wants to merge 1 commit into from

Conversation

nevir
Copy link
Contributor

@nevir nevir commented Apr 19, 2016

This allows effects to begin in a paused state, etc

This allows effects to begin in a paused state, etc
@nevir
Copy link
Contributor Author

nevir commented Apr 19, 2016

Oh, I need to do this on <Animation> too

@nevir nevir closed this Apr 19, 2016
@bringking
Copy link
Owner

Yeah sorry, I have been meaning to come up with an interface or base class that shares this common behavior between groups, sequences and basic Animations..

@nevir
Copy link
Contributor Author

nevir commented Apr 19, 2016

Yeah, no worries - I've got a patch on the way; currently just doing a simple mixin. Hopefully it fits into how you were thinking about organizing it

@nevir nevir deleted the patch-2 branch April 19, 2016 04:38
@nevir
Copy link
Contributor Author

nevir commented Apr 19, 2016

Better PR: #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants