Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose "write_chunk" functionality #12

Closed
JasperDeSutter opened this issue Jan 26, 2020 · 3 comments
Closed

expose "write_chunk" functionality #12

JasperDeSutter opened this issue Jan 26, 2020 · 3 comments

Comments

@JasperDeSutter
Copy link

The current API does not allow writing arbitrary chunks. This is because the Writer is not exposed on the Encoder struct, and the writer module is not public.
This is currently limiting me from using mtpng, as I need to be able to write extra/custom chunks other than allowed currently.
Maybe a new write_chunk method could be added to the Encoder that simply forwards to the inner Writer?

@bvibber
Copy link
Owner

bvibber commented Jan 28, 2020

Yes, something like that should be perfect for custom chunks. I'll take a peek at the code soon and see if I can hack it in. :)

@bvibber
Copy link
Owner

bvibber commented Jan 29, 2020

0.3.4 (5318501) should resolve this, let me know if it's working for you!

@JasperDeSutter
Copy link
Author

Thanks for adding this feature so fast! It's working perfectly fine for my needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants