Remove need to shim jquery-mockjax

[ericherdzik-zz]

As a user, it is inconvenient for me to have to shim jquery-mockjax in my Brisket application for bootstrapped data to work.

Acceptance Criteria Bootstrapped data functions correctly without the consumer having the shim any libraries.

[ericherdzik-zz]

You can assign this one to me. I'm starting a feature branch now based on the feedback @wawjr3d gave me on my previous attempt.

[ericherdzik-zz]

#15

[wawjr3d]

Looks like jquery-mockjax has changed ownership: https://github.com/jakerella/jquery-mockjax/releases/tag/v1.6.1

@ericherdzik you might be able to reach out to @jakerella for help

[jakerella]

Hi! What's the issue exactly? Happy to help if possible.

[ericherdzik-zz]

Hi @jakerella. Thanks for reaching out. The problem is that we are not able to package Mockjax as a Common JS package and automatically included when a consumer of Brisket uses Browserify. This forces the consumer to have to shim Mockjax and we would like to eliminate that step. If Mockjax were Common JS compliant on npm, all problems would be resolved.

[jakerella]

I can see how that would be a problem. We can certainly make mockjax Common JS compliant, but that's unlikely to happen before version 2.0.0 (our next planned release). This is primarily because we'll have to rewrite our tests (and write more) to account for this and ensure that the library can still be simply included in a page. Keep in mind we do accept PRs. ;)

That said, you could also fork the repo and wrap the code with the necessary IIFE and such, then in your dependencies list use the forked github user/repo.

[ericherdzik-zz]

We've been following this PR: jakerella/jquery-mockjax#103 but it seems that is has not gone anywhere. In the meantime, we can explore either forking or vendorizing a modified version that is Common JS compliant. Looking forward to 2.0.0! Thanks.

[jakerella]

Yep, that's the correct PR until I refactor the work for 2.0. Once I do that, there will be a new PR and reference to that old one. Sorry for the delay!

[ericherdzik-zz]

Locked pending: jakerella/jquery-mockjax#103

[wawjr3d]

@jakerella great work on 2.0.0 (no beta). everything's working great for us in the brisket world. keep it up :)

[jakerella]

Thanks!

@wawjr3d (et al) Please note that we (incorrectly) named the package "jquery.mockjax" in the 2.0.0 ga (and beta) when it should be "jquery-mockjax" (note the hyphen). I've updated the npm registry with a deprecation notice. You're listed there as a dependent, so be careful! I released 2.0.1 to fix the name, and that's the name you'll want to latch onto for all future releases.