Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create commonjs build target #67

Closed
miglesiasEB opened this issue Dec 2, 2017 · 0 comments · Fixed by #86
Closed

Create commonjs build target #67

miglesiasEB opened this issue Dec 2, 2017 · 0 comments · Fixed by #86
Labels
build enhancement
Projects
Release 1.0

Comments

@miglesiasEB
Copy link
Collaborator

Expected Behavior

We want to expose a commonjs versions of the modules. They would leave in /lib/cjs

Current Behavior

We just have umd

Possible Solution

Upgrading our build system to produce this
@miglesiasEB miglesiasEB added this to Backlog in Release 1.0 Dec 2, 2017
@Golodhros Golodhros mentioned this issue Dec 27, 2017
Merged
3 tasks
@miglesiasEB miglesiasEB moved this from Backlog to On Progress in Release 1.0 Jan 9, 2018
@miglesiasEB miglesiasEB moved this from On Progress to Done in Release 1.0 Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build enhancement
Projects
Release 1.0
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding CommonJS target on lib folder Golodhros/britecharts-react
1 participant
@miglesiasEB