Adding CommonJS target on lib folder #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Exctract barChart fixtures from testData * Extract donutChart fixtures from testData * Extract legendChart fixtures from testData, also rename to legendChart * Extract stackedAreaChart fixtures from testData * Fix LineComponent data proptype * Update requires to the new fixtures in documentation files
amber-eb
reviewed
Dec 27, 2017
yarn.lock
Outdated
| @@ -1365,9 +1365,27 @@ braces@^1.8.2: | |||
| preserve "^0.2.0" | |||
| repeat-element "^1.1.2" | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Yeah, good call. Fixing
Golodhros
force-pushed
the
mi-target-cjs
branch
from
838436d
to
26ffa66
Compare
jchen-eb
approved these changes
Dec 27, 2017
There was a problem hiding this comment.
This looks good for now.
We should consider looking at how recharts does it since it's much simpler and I think they get the same result we want.
https://github.com/recharts/recharts/blob/master/package.json
https://github.com/recharts/recharts/blob/master/webpack.config.js
Not sure yet if it will apply 100% to ours but it could be worth exploring.
miglesiasEB
pushed a commit
that referenced
this pull request
May 31, 2019
* try cleaning up travis yml * Bumped Project to 0.3.17 * try again * Bumped Project to 0.3.18 * go back to manual push * Bumped Project to 0.3.19 * bump britecharts * Bumped Project to 0.3.20 * bump to britecharst 2.4.6 * Bumped Project to 0.3.21 * try ghpages deploy with folder setting * Bumped Project to 0.3.22 * fix syntax * Bumped Project to 0.3.23 * Add Line chart (#72) * Extract fixtures from testData to its own folder (#76) * Exctract barChart fixtures from testData * Extract donutChart fixtures from testData * Extract legendChart fixtures from testData, also rename to legendChart * Extract stackedAreaChart fixtures from testData * Fix LineComponent data proptype * Update requires to the new fixtures in documentation files * Upgrade to latest britecharts * Adding CommonJS modules and updating esm configuration to use commonjs-modules * Fixing merge conflicts in lock file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a commonjs version of the individual files into our lib folder
Updating the format of the esm modules
Motivation and Context
Fixes https://github.com/eventbrite/britecharts-react/issues/67
Tries to get close to solve https://github.com/eventbrite/britecharts/issues/429
How Has This Been Tested?
Ran tests, checked outputs manually
Types of changes