Fix StackedBar chart tooltip rendering #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Tooltip component was wrongly assuming all charts had the .vertical-marker-container DOM Node causing the charts with no vertical mark to not being able to load the tooltip.
Golodhros
reviewed
Jun 3, 2019
| @@ -117,7 +118,7 @@ export default class Tooltip extends React.Component { | |||
| * | |||
| * @ignore | |||
| */ | |||
| data: PropTypes.object, | |||
| data: PropTypes.oneOfType([PropTypes.object, PropTypes.array]).isRequired, | |||
|
Awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tooltip rendering for the StackedBar chart is broken.
Description
The Tooltip component was wrongly assuming all charts had the
.vertical-marker-containerDOM Node causing the charts with no vertical mark to returnnullto the query and not being able to load the tooltip.This PR introduce the possibility to query the metadata container where no marker is included in the chart and pass that DOM Node instead.
Motivation and Context
The PR solves the problem with broken tooltips. https://github.com/eventbrite/britecharts-react/issues/150
How Has This Been Tested?
Unit tests has being created to test the case mentioned above.
Screenshots:
Types of changes
Checklist: