Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v6): use d3 v6 build with webpack 5 #1025

Open
wants to merge 1 commit into
base: release/3.0.0-rc6
Choose a base branch
from

Conversation

shayh
Copy link
Contributor

@shayh shayh commented Aug 16, 2023

Description

updated to latest d3 and webpack

Motivation and Context

most of d3 packages used by britecharts are outdated and have variability risks.

How Has This Been Tested?

  • ran all build scripts
  • played with all charts on the sandbox

Types of changes

  • Refactor (changes the way we code something without changing its functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Latest master code has been merged into this branch
  • No commented out code (if required, place // TODO above with explanation)
  • No linting issues
  • Build is successful
  • Code follows the API Guidelines
  • Updated the documentation
  • Added tests to cover changes
  • All new and existing tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant