Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Updates #181

Merged
merged 1 commit into from
Apr 1, 2017
Merged

Conversation

Golodhros
Copy link
Collaborator

In this commit, I tackled:

  • Fixing color selector 'undefined' element at the end
  • Updating Stacked Area Chart demo code example by simplifying the text and removing comments
  • Fixed brush styling
  • Adjusted x time axis by reducing the time range necessary to show the years and months

Motivation and Context

Updates on docs and X-axis, fixes brush styling

How Has This Been Tested?

Ran tests and checked visually

Screenshots (if appropriate):

britecharts_-d3_js_based_charting_library_of_reusable_components

fullscreen_3_31_17__3_33_pm

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Updating demo
Adjusting time axis granularity to show months and years when timeframe is less than one year
@Golodhros Golodhros merged commit f0e868c into britecharts:master Apr 1, 2017
miglesiasEB pushed a commit that referenced this pull request Dec 3, 2017
miglesiasEB pushed a commit that referenced this pull request Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant