Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'Thank God' by Sasha Sloan #373

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added 'Thank God' by Sasha Sloan #373

wants to merge 2 commits into from

Conversation

hp-plus5
Copy link

[x] πŸ”Ž Have searched the data.js file and Pull Requests to make sure that you are not adding a duplicate.
[x] πŸ–οΈ Place the song(s) are placed in alphabetical order based on title inside of the data.js file.
[x] πŸ–οΈ The artist(s) and featured artist(s) are all inside of square brackets [ ] and each are individually wrapped in quotation marks and have a comma between each one. (such as submitting this "artist": ["Lady Gaga","Bradley Cooper"] and not this "genres":["Lady Gaga,Bradley Cooper"]).
[x] There are at least three emojis listed under emojiImgs
[x] There are a maxium of six emojis listed under emojiImgs.
[x] πŸ–οΈ There is a link to an official music video or performance under musicVideo. If there is no official video, I have added an empty string.
[x] πŸ‘ The pull request has a descriptive title (such as Added Boy With Luv or Added all of Panic at the Disco songs)
[x] ⭐ The genres are all inside of square brackets [ ] and each are individually wrapped in quotation marks and have a comma between each one. (such as submitting this "genres": ["k-pop","pop","dance"] and not this "genres":["k-pop, pop, dance"]).
[x] πŸ“… There is a single year under year.

@auto-comment
Copy link

auto-comment bot commented Oct 27, 2019

Thank you for opening this pull request, your code will be reviewed soon! Please follow the contribution guidelines outlined in the README.
If you did not follow the instructions for contributing to this project this pull request will be closed and marked invalid.
If your pull request status (at the bottom of this page) says "This branch has conflicts that must be resolved", please resolve the conflicts so that we can review your changes.

@brittanyrw brittanyrw added the invalid PRs that should be closed label Oct 30, 2019
@hp-plus5
Copy link
Author

Hey, I saw that you labeled as 'invalid'. What can be done to make this valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid PRs that should be closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants