Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added firefly #324

Closed
wants to merge 1 commit into from
Closed

Conversation

lesliewelch-zz
Copy link

  • [x ] πŸ” I have searched the data.js file and confirmed I am not adding a duplicate entry. Note: Different versions of the same show/movie are okay to add such as Lion King (1994) and Lion King (2019) or Rent (movie) and Rent (musical).
  • [x ] 🌈 I have added a single year under year. Note: Do not add ranges such as 2017-2019.
  • [x ] πŸ“… I have added a type from one of the following: movie , tv or musical.
  • [x ] πŸ”— I have added the IMDB page or Playbill archive page under itemLink.
  • [x ] 3️⃣ I have at least three emojis listed under emojiImgs.
  • [x ] 5️⃣ I have a maximum of five emojis listed under emojiImgs.
  • [x ] πŸ‘ My pull request has a descriptive title (such as Added The Lion King or Added Black Panther, The Avengers: Endgame and Thor).
  • [x ] ⭐ My genres are all inside of square brackets [ ] and each are individually wrapped in quotation marks and have a comma between each one. (such as submitting this "genres": ["adventure","mystery","animation"] and not this "genres":["adventure, mystery, animation"]).
  • [x ] πŸ–οΈ I have placed the new show(s) or movie(s) in alphabetical order based on title. If the show or movie starts with 'the', then use the second word to alphabetize.

@brittanyrw brittanyrw added the WIP or Requires Updates WIP or requires updates label Oct 2, 2019
@stale stale bot added the closing label Oct 18, 2019
Repository owner deleted a comment from stale bot Oct 18, 2019
@brittanyrw brittanyrw closed this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP or Requires Updates WIP or requires updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants