Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uberauthenticator duplicate function with different bodies #54

Open
erkattak opened this issue Sep 11, 2017 · 1 comment
Open

Uberauthenticator duplicate function with different bodies #54

erkattak opened this issue Sep 11, 2017 · 1 comment

Comments

@erkattak
Copy link

The second of these two functions doesn't seem like it would ever run:

https://github.com/britton-jb/sentinel/blob/master/lib/sentinel/ueberauthenticator.ex#L29-L45

@britton-jb
Copy link
Owner

I believe they should be able to run, based on the guard clauses, but that would be easy to miss given how far off the page they run. I'll try to get a fix for that.

And sorry about the delay in response. Don't know how I missed this one.

britton-jb added a commit that referenced this issue Nov 4, 2017
suranyami pushed a commit to suranyami/sentinel that referenced this issue Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants