Add scrollbar.horizontal
#74
Conversation
| @@ -66,6 +66,7 @@ nodes { | |||
| alpha: 1.0 | |||
| template_node_child: false | |||
| size_mode: SIZE_MODE_MANUAL | |||
| custom_type: 0 | |||
There was a problem hiding this comment.
thought: I don't know what these are about, but the editor added it to all components.
There was a problem hiding this comment.
Ah, this is a new thing introduced with custom GUI nodes, such as Spine nodes from the Spine extension.
|
|
||
| scrollbar.refresh() | ||
| return scrollbar | ||
| end |
There was a problem hiding this comment.
thought: This part is mostly copy-pasted from vertical, which I'm not super happy about. However, I thought introducing abstractions to keep things DRY would make it less readable. I defer to you @britzl.
There was a problem hiding this comment.
I think this is perfectly fine to be honest. Sure, the first 20 lines or so could be moved to a shared function perhaps, but lets keep it as it is!
gooey/internal/scrollbar.lua
Outdated
|
|
||
| scrollbar.enabled = core.is_enabled(handle) | ||
| scrollbar.node = handle | ||
| scrollbar.node_id = node_id |
There was a problem hiding this comment.
issue: Oops, node_id is never defined in here! M.vertical has the same problem!
@britzl was the original intention to set scrollbar.node_id = handle_id?
(It can also serve as a slider, which is what I needed for adjusting music and sound fx volumes in my game. 馃槄)
Modified the example GUI to show it in action:
horizontal_scrollbar.mp4