Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comma-separated nums regression test (fails until fix is added) #72

Merged
merged 2 commits into from
Dec 6, 2021
Merged

Comma-separated nums regression test (fails until fix is added) #72

merged 2 commits into from
Dec 6, 2021

Conversation

artoonie
Copy link
Collaborator

@artoonie artoonie commented Dec 6, 2021

No description provided.

@artoonie artoonie changed the title [WIP] Comma-separated nums regression test (fails until fix is added) Comma-separated nums regression test (fails until fix is added) Dec 6, 2021
@coveralls
Copy link

coveralls commented Dec 6, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1542594235

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+3.1%) to 94.609%
Files with Coverage Reduction New Missed Lines %
data-table/table.js 6 94.61%
Totals Coverage Status
Change from base Build 1541748075: 3.1%
Covered Lines: 277
Relevant Lines: 288
💛 - Coveralls

@fotakis08 fotakis08 self-requested a review December 6, 2021 00:57
@artoonie artoonie merged commit 09d2a13 into main Dec 6, 2021
@artoonie artoonie deleted the test-for-comma-separated-nums branch December 6, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kha6Shafiei Kha6Shafiei Kha6Shafiei approved these changes

@fotakis08 fotakis08 fotakis08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@artoonie @coveralls @Kha6Shafiei @fotakis08