Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds i18Next support to React #290

Merged
merged 11 commits into from
Dec 21, 2021
Merged

Adds i18Next support to React #290

merged 11 commits into from
Dec 21, 2021

Conversation

oicramps
Copy link
Sponsor Collaborator

@oicramps oicramps commented Dec 5, 2021

Summary

Configures react-i18next to handle internationalization in the react codebase

Depends on: Typescript support to React #289

@oicramps oicramps added Frontend Improvement Product improvement labels Dec 5, 2021
@oicramps oicramps self-assigned this Dec 5, 2021
@oicramps oicramps changed the base branch from development to feature/react-typescript December 12, 2021 18:02
@oicramps oicramps changed the base branch from feature/react-typescript to development December 12, 2021 18:04
@idmarjr
Copy link
Sponsor Collaborator

idmarjr commented Dec 18, 2021

@oicramps We have some conflicts here. Other than that, is this good to go?

@oicramps
Copy link
Sponsor Collaborator Author

@oicramps We have some conflicts here. Other than that, is this good to go?

I'll solve the conflicts later today, and then we are good to go. I'll let you know when the PR is ready to merge

@oicramps
Copy link
Sponsor Collaborator Author

@idmarjr I've solved the conflicts

Copy link
Sponsor Collaborator

@idmarjr idmarjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go-to-go

@oicramps oicramps merged commit b4bcc4b into development Dec 21, 2021
@oicramps oicramps deleted the feature/react-i18n branch December 21, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Improvement Product improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants