Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Export model #301

Closed
wants to merge 21 commits into from
Closed

Feature: Export model #301

wants to merge 21 commits into from

Conversation

idmarjr
Copy link
Sponsor Collaborator

@idmarjr idmarjr commented Dec 12, 2021 •
edited
Loading

Summary

Allow users to export a model, downloading a .brt file to their local computer.

Resolve #75

Screenshots

List of Models Logic workspace Conceptual workspace
Screen Shot 2021-12-12 at 12 43 29 Screen Shot 2021-12-12 at 12 44 08 Screen Shot 2021-12-12 at 12 44 27

To do

  • Define metada to include in the file
    • Model name
    • Author
    • Author email (optional?)
    • Creation date
    • Last edit
    • Export date
    • Model description (If yes, we need to add this capability)
  • Export modal

@idmarjr
Add Export model button to list of models page
dbc67b3
@idmarjr
Add export model button to Logic model workspace
6de196c
@idmarjr
Add export model button to cConceptual model workspace
3b56200
@idmarjr
Remove aria-hidden from actions in models list
689952d 
- aria-hidden hide element from screen readers
- aria-hidden should be used only if the icons have no semantic value.
- Since those icons have a meaning and are important actions to all users, we should no use aria-hidden here
@idmarjr idmarjr self-assigned this Dec 12, 2021
@idmarjr idmarjr changed the title Feature: export model Feature: Export model Dec 12, 2021
@idmarjr
Copy link
Sponsor Collaborator Author

idmarjr commented Dec 12, 2021

@miltonbsn @oicramps @ArthurMota9

Please take a look at the To do section.
Please review the metadata items we will embed to the exported file.

Questions

  • What else can/should we add to the exported file?
  • What should we DO NOT include in the file?

@miltonbsn miltonbsn self-requested a review December 13, 2021 02:19
@idmarjr idmarjr mentioned this pull request Dec 15, 2021
Closed
4 tasks
@idmarjr idmarjr mentioned this pull request Aug 22, 2023
Closed
miltonbsn and others added 13 commits September 17, 2023 16:55
@miltonbsn
Validate user on get model
a13e645
@idmarjr @miltonbsn
Move .separator to atomic.scss
7a18bfd
@idmarjr @miltonbsn
No access page
f859605 
- Markup
- Styles
- Translations
@miltonbsn
Remove debbug code
6aa1fa6
@miltonbsn
Fix typo
378ce39
@miltonbsn
Validade user on get logic model
3edc0f9
@miltonbsn
Set log on error
007ce1c
@joaomfiumari @miltonbsn
feat(config): Add config file to centralize the env var loads
8b0e1aa
@joaomfiumari @miltonbsn
feat(auth): Add jwt middleware to validate received access-token
84551cb
@joaomfiumari @miltonbsn
feat(auth): Add interceptor to add jwt token in the requests
680f141
@dependabot
Bump jsonwebtoken from 8.5.1 to 9.0.0
e16750b 
Bumps [jsonwebtoken](https://github.com/auth0/node-jsonwebtoken) from 8.5.1 to 9.0.0.
- [Changelog](https://github.com/auth0/node-jsonwebtoken/blob/master/CHANGELOG.md)
- [Commits](auth0/node-jsonwebtoken@v8.5.1...v9.0.0)

---
updated-dependencies:
- dependency-name: jsonwebtoken
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@miltonbsn
Merge pull request #468 from brmodeloweb/dependabot/npm_and_yarn/json…
1110104 
…webtoken-9.0.0

Bump jsonwebtoken from 8.5.1 to 9.0.0
@idmarjr
Merge branch 'main' into feature/export-model
ccea7fa
@idmarjr
Copy link
Sponsor Collaborator Author

idmarjr commented Feb 4, 2024

Considering this merge request is 2+ years old, I'm closing it.
If we decide to get back to work in this feature in the future, we can re-open it or create a new one.

@idmarjr idmarjr closed this Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miltonbsn miltonbsn Awaiting requested review from miltonbsn

Assignees

@idmarjr idmarjr

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export model
3 participants
@idmarjr @miltonbsn @joaomfiumari