Better handling of fw fetch.

brndnmtthws · Dec 2, 2018 · 63e7c40 · 63e7c40
1 parent 82f521d
commit 63e7c40
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/mother_of_dragons/firmware.py b/mother_of_dragons/firmware.py
@@ -26,11 +26,13 @@ def get_firmware_path(self, url):
             gevent.sleep(1)
         if filename in self.firmwares:
             return self.firmwares[filename]
-        elif filename not in self.firmwares_to_fetch:
+        else:
             self.firmwares_being_fetched.add(filename)
             # file doesn't exist locally, fetch it
-            result = self._fetch_firmware(url, filename)
-            self.firmwares_being_fetched.discard(filename)
+            try:
+                result = self._fetch_firmware(url, filename)
+            finally:
+                self.firmwares_being_fetched.discard(filename)
             return result
 
     def _fetch_firmware(self, url, filename):