Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a lambda for minimum price #370

Merged
merged 2 commits into from Feb 16, 2024
Merged

Use a lambda for minimum price #370

merged 2 commits into from Feb 16, 2024

Conversation

brndnmtthws
Copy link
Owner

When scanning chains, sometimes the underlying can move a fair bit and it moves the minimum prices around if there's a big move. Instead of calculating the minimum price once, we'll use a lambda so that if there is a big change, it should be accounted for appropriately. This could lead to some odd behaviour, but it should still be less bad than the alternative which is using an out-of-date price.

When scanning chains, sometimes the underlying can move a fair bit and
it moves the minimum prices around if there's a big move. Instead of
calculating the minimum price once, we'll use a lambda so that if there
is a big change, it should be accounted for appropriately. This could
lead to some odd behaviour, but it should still be less bad than the
alternative which is using an out-of-date price.
@brndnmtthws brndnmtthws merged commit 704d400 into main Feb 16, 2024
8 checks passed
@brndnmtthws brndnmtthws deleted the better-scanning branch February 16, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant