Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous assertions in the tests #8

Open
pgrt opened this issue Dec 14, 2023 · 0 comments
Open

Ambiguous assertions in the tests #8

pgrt opened this issue Dec 14, 2023 · 0 comments

Comments

@pgrt
Copy link

pgrt commented Dec 14, 2023

Hello,

While packaging version 1.1.0 of http-nio in Debian, I got test failures related to ambiguous assertions:

/<>/src/test/java/org/broadinstitute/http/nio/RetryHandlerUnitTest.java:75: error: reference to assertEquals is ambiguous
Assert.assertEquals(DEFAULT_RETRY_HANDLER.runWithRetries(() -> 3), 3);
^
both method assertEquals(Object,Object) in Assert and method assertEquals(int,int) in Assert match
/<>/src/test/java/org/broadinstitute/http/nio/RetryHandlerUnitTest.java:103: error: reference to assertEquals is ambiguous
Assert.assertEquals(DEFAULT_RETRY_HANDLER.tryOnceThenWithRetries(
^
both method assertEquals(Object,Object) in Assert and method assertEquals(int,int) in Assert match
/<>/src/test/java/org/broadinstitute/http/nio/RetryHandlerUnitTest.java:113: error: reference to assertEquals is ambiguous
Assert.assertEquals(DEFAULT_RETRY_HANDLER.tryOnceThenWithRetries(
^
both method assertEquals(Object,Object) in Assert and method assertEquals(int,int) in Assert match
/<>/src/test/java/org/broadinstitute/http/nio/RetryHandlerUnitTest.java:147: error: reference to assertEquals is ambiguous
Assert.assertEquals(DEFAULT_RETRY_HANDLER.tryOnceThenWithRetries(
^
both method assertEquals(Object,Object) in Assert and method assertEquals(int,int) in Assert match
/<>/src/test/java/org/broadinstitute/http/nio/RetryHandlerUnitTest.java:176: error: reference to assertEquals is ambiguous
Assert.assertEquals(NO_RETRIES_HANDLER.runWithRetries(() -> 3), 3);
^
both method assertEquals(Object,Object) in Assert and method assertEquals(int,int) in Assert match

The enclosed patch fixes this.

Best,

Pierre

ambiguous_assertions.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant