Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided high level descriptions for tasks and workflows without such docs #24

Closed
SHuang-Broad opened this issue Sep 22, 2019 · 7 comments

Comments

@SHuang-Broad
Copy link
Collaborator

No description provided.

@SHuang-Broad SHuang-Broad added the TODO tasks and people can adopt, preferably easy tasks label Sep 22, 2019
@SHuang-Broad SHuang-Broad added documentation and removed TODO tasks and people can adopt, preferably easy tasks labels May 27, 2020
@SHuang-Broad SHuang-Broad added the review-party things to be handled in the next review party label Jun 12, 2020
@kvg
Copy link
Collaborator

kvg commented Jul 13, 2020

@SHuang-Broad to come up with the task ownership list for documentation responsibilities.

@SHuang-Broad
Copy link
Collaborator Author

15 root level WDLs

WDLs/root level workflows

CanuRunner.wdl
RaconRunner.wdl
QuastRunner.wdl
GuppyRunner.wdl
TestCromwell.wdl
MedakaRunner.wdl
NanopolishRunner.wdl
PB10xSingleFlowcell.wdl
ONT10xSingleFlowcell.wdl
TrioBinChildLongReads.wdl
PBCCSOnlySingleFlowcell.wdl
PB10xSingleProcessedSample.wdl
ONTWholeGenomeSingleFlowcell.wdl
PBCCSWholeGenomeSingleFlowcell.wdl
PBCLRWholeGenomeSingleFlowcell.wdl

subworkflows

WDL FILE LINE NUMBER SUB-WORKFLOW
AlignedMetrics.wdl 6 workflow AlignedMetrics
AssembleMT.wdl 6 workflow AssembleMT
AssignChildLongReads.wdl 5 workflow AssignChildLongReadsGivenParentalKmerStats
C3POa.wdl 6 workflow C3POa
CallSVs.wdl 5 workflow CallSVs
CallSmallVariants.wdl 6 workflow CallSmallVariants
Canu.wdl 5 workflow CorrectTrimAssemble
CollectParentsKmerStats.wdl 6 workflow CollectParentsKmerStats
DeepVariantLR.wdl 84 workflow TestCallDeepVariant
DownloadFromSRA.wdl 21 workflow DownloadFromSRA
Figures.wdl 7 workflow Figures
GATKBestPractice.wdl 15 workflow GATKBestPraciceForLR
Guppy.wdl 5 workflow Guppy
Nanopolish.wdl 5 workflow PolishAssembly
Peregrine.wdl 5 workflow Peregrine
PhaseReads.wdl 5 workflow PhaseReads
UnalignedMetrics.wdl 6 workflow UnalignedMetrics

28 WDLs in "./tasks/"

Canu.wdl
Utils.wdl
C3POa.wdl
Guppy.wdl
Quast.wdl
Racon.wdl
Medaka.wdl
PBUtils.wdl
CallSVs.wdl
Figures.wdl
ONTUtils.wdl
NanoPlot.wdl
Finalize.wdl
Peregrine.wdl
Nanopolish.wdl
AlignReads.wdl
PhaseReads.wdl
AssembleMT.wdl
DeepVariantLR.wdl
AlignedMetrics.wdl
AssembleTarget.wdl
DownloadFromSRA.wdl
GATKBestPractice.wdl
UnalignedMetrics.wdl
AnnotateAdapters.wdl
CallSmallVariants.wdl
AssignChildLongReads.wdl
CollectParentsKmerStats.wdl

@SHuang-Broad
Copy link
Collaborator Author

SHuang-Broad commented Jul 14, 2020

Assignment

Everyone, please pick the workflows that you authored and generate a check list on which

  • root level workflows
  • sub-workflows

and since all except utility WDLs are self-contained at this stage,

  • all tasks in the picked WDL files.

And while we are addressing this issue, please also do the following in your PRs:

  • remove commented out code blocks
  • provide parameter_meta for all tasks. Note that while doing this, I came to the compromise that not all tasks need these, but all workflows and all tasks that are referenced out of its defining files must do.

Based on history, I've generated the following assignment. Feel free to pick more or unassign yourself if I made a mistake.

@SHuang-Broad
Copy link
Collaborator Author

SHuang-Broad commented Jul 14, 2020

@ericsong

Root level

  • CanuRunner.wdl
  • RaconRunner.wdl
  • QuastRunner.wdl
  • GuppyRunner.wdl
  • MedakaRunner.wdl
  • NanopolishRunner.wdl

Task level

  • Canu.wdl
  • Guppy.wdl
  • Quast.wdl
  • Racon.wdl
  • Medaka.wdl
  • Nanopolish.wdl

@SHuang-Broad
Copy link
Collaborator Author

SHuang-Broad commented Jul 14, 2020

@SHuang-Broad

Root level

  • TrioBinChildLongReads.wdl
  • PBCCSOnlySingleFlowcell.wdl

Task level

  • CallSVs.wdl
  • Peregrine.wdl
  • AlignReads.wdl
  • DeepVariantLR.wdl
  • DownloadFromSRA.wdl
  • GATKBestPractice.wdl
  • CallSmallVariants.wdl
  • AssignChildLongReads.wdl
  • CollectParentsKmerStats.wdl

@SHuang-Broad
Copy link
Collaborator Author

SHuang-Broad commented Jul 14, 2020

@kvg

Root level

  • TestCromwell.wdl
  • PB10xSingleFlowcell.wdl
  • ONT10xSingleFlowcell.wdl
  • PB10xSingleProcessedSample.wdl
  • PBCCSWholeGenomeSingleFlowcell.wdl
  • PBCLRWholeGenomeSingleFlowcell.wdl
  • ONTWholeGenomeSingleFlowcell.wdl

1-off tasks?

The following tasks exist in root level workflows. Consider if they should be moved to "tasks/".

WORKFLOW LINE NUMBER TASK
TestCromwell.wdl 13 task TestCromwellOnGCS
ONT10xSingleFlowcell.wdl 251 task AnnotateAdapters
PB10xSingleProcessedSample.wdl 200 task RevertBam
PB10xSingleProcessedSample.wdl 243 task SplitBam
PB10xSingleProcessedSample.wdl 284 task GetRunInfo

Task level

  • Utils.wdl
  • C3POa.wdl
  • PBUtils.wdl
  • Figures.wdl
  • ONTUtils.wdl
  • NanoPlot.wdl
  • Finalize.wdl
  • PhaseReads.wdl
  • AssembleMT.wdl
  • AssembleTarget.wdl
  • AlignedMetrics.wdl
  • UnalignedMetrics.wdl
  • AnnotateAdapters.wdl

@SHuang-Broad
Copy link
Collaborator Author

closed by #424

@SHuang-Broad SHuang-Broad unpinned this issue Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants