model factory refactor #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndiamant
commented
Apr 8, 2020
ml4cvd/tensor_generators.py
Outdated
Comment on lines
570
to
571
| sample_weights = [None] * len(out_batch) | ||
| return (in_batch, out_batch, sample_weights, paths) if return_paths else (in_batch, out_batch, sample_weights) |
There was a problem hiding this comment.
This is the same as master, not sure why it's presented as a change
ndiamant
commented
Apr 8, 2020
ml4cvd/tensor_generators.py
Outdated
Comment on lines
617
to
618
| sample_weights = [in_batch.pop(sample_weight.input_name()).flatten()] * len(out_batch) | ||
| return (in_batch, out_batch, sample_weights, paths) if return_paths else (in_batch, out_batch, sample_weights) |
There was a problem hiding this comment.
This is the same as master, not sure why it's presented as a change
lucidtronix
force-pushed
the
nd_model_factory_refactor
branch
from
9870821
to
7b61c75
Compare
lucidtronix
force-pushed
the
nd_model_factory_refactor
branch
from
401a5a1
to
96b4055
Compare
…nstitute/ml into nd_model_factory_refactor
…nstitute/ml into nd_model_factory_refactor
lucidtronix
approved these changes
May 13, 2020
|
After running tests pushing new dockers for CPU & GPU and pre-commit hooking I think this is good to merge. |
mklarqvist
pushed a commit
that referenced
this pull request
Jun 2, 2020
Lots of changes to model factory! List here https://docs.google.com/document/d/15sZsTnDVOiBPlW16FX36IzEx-FS7p0YxQ7alY_-npjE/edit?usp=sharing
lucidtronix
pushed a commit
that referenced
this pull request
Jan 13, 2023
Lots of changes to model factory! List here https://docs.google.com/document/d/15sZsTnDVOiBPlW16FX36IzEx-FS7p0YxQ7alY_-npjE/edit?usp=sharing
lucidtronix
pushed a commit
that referenced
this pull request
Jan 13, 2023
Lots of changes to model factory! List here https://docs.google.com/document/d/15sZsTnDVOiBPlW16FX36IzEx-FS7p0YxQ7alY_-npjE/edit?usp=sharing
lucidtronix
pushed a commit
that referenced
this pull request
Jan 13, 2023
Lots of changes to model factory! List here https://docs.google.com/document/d/15sZsTnDVOiBPlW16FX36IzEx-FS7p0YxQ7alY_-npjE/edit?usp=sharing
lucidtronix
pushed a commit
that referenced
this pull request
Jan 13, 2023
Lots of changes to model factory! List here https://docs.google.com/document/d/15sZsTnDVOiBPlW16FX36IzEx-FS7p0YxQ7alY_-npjE/edit?usp=sharing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_variational..., which will soon be deprecatedHere is a model with
u_connect, multiple inputs, multiple outputs, and parented outputs