Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further work for contracts to use interfaces instead of abstract classes #40

Merged
merged 1 commit into from Oct 6, 2014
Merged

further work for contracts to use interfaces instead of abstract classes #40

merged 1 commit into from Oct 6, 2014

Conversation

kelvinj
Copy link
Contributor

@kelvinj kelvinj commented Sep 7, 2014

Changes include:

  • a new ProjectorInterface for the Projector abstract class
  • CommandHandling and ReadModel scenarios to use interfaces rather than abstract classes
  • EventSourcedAggregateRoot::initializeState typehints the DomainEventStreamInterface instead of DomainEventStream

This is a follow-up to PR #2

@sstok
Copy link

sstok commented Sep 7, 2014

👍

@@ -16,6 +16,7 @@
use Broadway\Domain\Metadata;
use Broadway\ReadModel\InMemory\InMemoryRepository;
use Broadway\ReadModel\Projector;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused since you use the interface now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Miliooo thanks.

Changes include:

- a new ProjectorInterface for the Projector abstract class
- CommandHandling and ReadModel scenarios to use interfaces rather than abstract classes
@wjzijderveld
Copy link
Member

👍

Sorry for the delay!

@fritsjanb
Copy link
Contributor

👍

Thanks for the pull @kelvinj

fritsjanb added a commit that referenced this pull request Oct 6, 2014
further work for contracts to use interfaces instead of abstract classes
@fritsjanb fritsjanb merged commit 3ce4f63 into broadway:master Oct 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants