New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further work for contracts to use interfaces instead of abstract classes #40

Merged
merged 1 commit into from Oct 6, 2014

Conversation

Projects
None yet
5 participants
@kelvinj
Contributor

kelvinj commented Sep 7, 2014

Changes include:

  • a new ProjectorInterface for the Projector abstract class
  • CommandHandling and ReadModel scenarios to use interfaces rather than abstract classes
  • EventSourcedAggregateRoot::initializeState typehints the DomainEventStreamInterface instead of DomainEventStream

This is a follow-up to PR #2

@sstok

This comment has been minimized.

Show comment
Hide comment
@sstok

sstok commented Sep 7, 2014

👍

@Miliooo

View changes

Show outdated Hide outdated src/Broadway/ReadModel/Testing/Scenario.php
@@ -16,6 +16,7 @@
use Broadway\Domain\Metadata;
use Broadway\ReadModel\InMemory\InMemoryRepository;
use Broadway\ReadModel\Projector;

This comment has been minimized.

@Miliooo

Miliooo Sep 7, 2014

Contributor

Unused since you use the interface now

@Miliooo

Miliooo Sep 7, 2014

Contributor

Unused since you use the interface now

This comment has been minimized.

@kelvinj

kelvinj Sep 7, 2014

Contributor

@Miliooo thanks.

@kelvinj

kelvinj Sep 7, 2014

Contributor

@Miliooo thanks.

further work for contracts to use interfaces instead of abstract classes
Changes include:

- a new ProjectorInterface for the Projector abstract class
- CommandHandling and ReadModel scenarios to use interfaces rather than abstract classes
@wjzijderveld

This comment has been minimized.

Show comment
Hide comment
@wjzijderveld

wjzijderveld Sep 23, 2014

Member

👍

Sorry for the delay!

Member

wjzijderveld commented Sep 23, 2014

👍

Sorry for the delay!

@fritsjanb

This comment has been minimized.

Show comment
Hide comment
@fritsjanb

fritsjanb Oct 6, 2014

Contributor

👍

Thanks for the pull @kelvinj

Contributor

fritsjanb commented Oct 6, 2014

👍

Thanks for the pull @kelvinj

fritsjanb added a commit that referenced this pull request Oct 6, 2014

Merge pull request #40 from brightmachine/2-contracts-using-interfaces
further work for contracts to use interfaces instead of abstract classes

@fritsjanb fritsjanb merged commit 3ce4f63 into broadway:master Oct 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment