New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typehint against DomainEventStreamInterface instead of concrete implementation #71

Merged
merged 1 commit into from Nov 6, 2014

Conversation

Projects
None yet
3 participants
@rjkip
Contributor

rjkip commented Oct 31, 2014

No description provided.

@wjzijderveld

View changes

Show outdated Hide outdated src/Broadway/EventSourcing/EventStreamDecoratorInterface.php
* @param string $aggregateType
* @param string $aggregateIdentifier
* @param DomainEventStream $eventStream
* @param string $aggregateType

This comment has been minimized.

@wjzijderveld

wjzijderveld Nov 3, 2014

Member

Please align the variables with each other.

@wjzijderveld

wjzijderveld Nov 3, 2014

Member

Please align the variables with each other.

This comment has been minimized.

@rjkip

rjkip Nov 3, 2014

Contributor

Done.

@rjkip

rjkip Nov 3, 2014

Contributor

Done.

@rjkip

This comment has been minimized.

Show comment
Hide comment
@rjkip

rjkip Nov 3, 2014

Contributor

We probably should fix this as well sometime, but that's not for this pull : https://github.com/rjkip/broadway/blob/499fcecfbee58062b523a146e058fe54405cfd50/src/Broadway/EventSourcing/MetadataEnrichment/MetadataEnrichingEventStreamDecorator.php#L60

Not seeing it, what's there to fix? :o

Contributor

rjkip commented Nov 3, 2014

We probably should fix this as well sometime, but that's not for this pull : https://github.com/rjkip/broadway/blob/499fcecfbee58062b523a146e058fe54405cfd50/src/Broadway/EventSourcing/MetadataEnrichment/MetadataEnrichingEventStreamDecorator.php#L60

Not seeing it, what's there to fix? :o

@wjzijderveld

This comment has been minimized.

Show comment
Hide comment
@wjzijderveld

wjzijderveld Nov 3, 2014

Member

As input we now typehint the interface, but the output is always an instance of DomainEventStream.

Member

wjzijderveld commented Nov 3, 2014

As input we now typehint the interface, but the output is always an instance of DomainEventStream.

@wjzijderveld

This comment has been minimized.

Show comment
Hide comment
Member

wjzijderveld commented Nov 3, 2014

👍

@wjzijderveld

This comment has been minimized.

Show comment
Hide comment
@wjzijderveld

wjzijderveld Nov 6, 2014

Member

ping @qandidate-labs/broadway

Member

wjzijderveld commented Nov 6, 2014

ping @qandidate-labs/broadway

@asm89

This comment has been minimized.

Show comment
Hide comment
@asm89

asm89 Nov 6, 2014

Member

@wjzijderveld Can you create an issue for the other thing? (not sure if it's actually a problem though :) )

As for this pull 👍 .

Member

asm89 commented Nov 6, 2014

@wjzijderveld Can you create an issue for the other thing? (not sure if it's actually a problem though :) )

As for this pull 👍 .

wjzijderveld added a commit that referenced this pull request Nov 6, 2014

Merge pull request #71 from rjkip/maintenance/event-stream-typehint
Typehint against DomainEventStreamInterface instead of concrete implementation

@wjzijderveld wjzijderveld merged commit 6093c7c into broadway:master Nov 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@rjkip rjkip deleted the rjkip:maintenance/event-stream-typehint branch Nov 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment