Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Publishers.Breakpoint and Publishers.HandleEvents #118

Merged
merged 3 commits into from
Dec 9, 2019

Conversation

broadwaylamb
Copy link
Member

No description provided.

@broadwaylamb broadwaylamb added the missing functionality This functionality is present in Apple's Combine but we don't have it yet label Dec 3, 2019
@broadwaylamb broadwaylamb mentioned this pull request Dec 3, 2019
83 tasks
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #118 into master will decrease coverage by 0.08%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   98.12%   98.03%   -0.09%     
==========================================
  Files          70       74       +4     
  Lines        3620     3823     +203     
==========================================
+ Hits         3552     3748     +196     
- Misses         68       75       +7
Impacted Files Coverage Δ
.../OpenCombine/Publishers/Publishers.ReceiveOn.swift 100% <ø> (ø) ⬆️
.../OpenCombine/Publishers/Publishers.DropWhile.swift 100% <ø> (ø) ⬆️
...rces/OpenCombine/Publishers/Publishers.Print.swift 100% <ø> (ø) ⬆️
...penCombine/Publishers/Publishers.SubscribeOn.swift 100% <ø> (ø) ⬆️
...penCombine/Publishers/Publishers.Autoconnect.swift 100% <ø> (ø) ⬆️
...urces/OpenCombine/Publishers/Publishers.Drop.swift 100% <ø> (ø) ⬆️
...es/OpenCombine/Publishers/Publishers.FlatMap.swift 100% <ø> (ø) ⬆️
.../OpenCombine/Publishers/Publishers.Multicast.swift 100% <ø> (ø) ⬆️
Sources/OpenCombine/Publishers/Record.swift 100% <ø> (ø) ⬆️
...rces/OpenCombine/Publishers/Publishers.Delay.swift 100% <ø> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d5d1e...0a1b227. Read the comment docs.

@OpenCombineBot
Copy link

OpenCombineBot commented Dec 3, 2019

LGTM

Generated by 🚫 Danger Swift against 0a1b227

CocoaPods doesn't support multiple Swift modules in the same pod.
Build COpenCombineHelpers sources together with OpenCombine sources
as a single module.

Previously COpenCombineHelpers was a separate pod. This was suboptimal,
as it made making changes in both targets very hard: you'd have to
push COpenCombineHelpers to trunk in order to pass validation.
@broadwaylamb broadwaylamb merged commit a300fd0 into master Dec 9, 2019
@broadwaylamb broadwaylamb deleted the breakpoint branch December 9, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing functionality This functionality is present in Apple's Combine but we don't have it yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants