Fix to show Network Server Name column in Service Profile List.

[sagar-patel-sls]

Fix to show Network Server Name column in Service Profile List

@brocaar Please review my change

Thanks

[brocaar]

Is this correct? An organization user is optional, so I believe with an inner join, if no org. user exists, the service-profile is not counted.

[sagar-patel-sls]

Filter on user ID
when an organizationID is not set and the user is not a global admin then the organization user will add in query

[brocaar]

@sagar-patel-sls I believe the above commit (5cdc262) should fix the issue. I have also added an additional test (+ refactored the Go Convey based tests into testify based tests, as I want to move away from Go Convey).

Is this correct? An organization user is optional, so I believe with an inner join, if no org. user exists, the service-profile is not counted.

What I mean which this is that in this case there must be a match between organization and organization user. This could be valid when you only have a global admin user for example. By changing the left join into an inner join, both the organization and organization user must exist. In case of a left join, you will get null values when no organization user match is found, that should be the intended behavior I believe so that you don't eliminate organizations without org. users from the result set.