Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please change examples to funnel, not new Funnel #41

Closed
alanhogan opened this issue Aug 21, 2015 · 2 comments
Closed

Please change examples to funnel, not new Funnel #41

alanhogan opened this issue Aug 21, 2015 · 2 comments

Comments

@alanhogan
Copy link

In short, documenting Funnel as a class is leading some devs to treat Funnel differently than other Broccoli and even Node modules. Look how Funnel sticks out like a sore thumb:

var mergeTrees = require('broccoli-merge-trees'),
    Funnel = require('broccoli-funnel'),
    concat = require('broccoli-concat'),
    path = require('path'),
    find = require('lodash/collection/find'),
    fs = require('fs');

If I made a brief PR to change example usages in README, would you accept it?

@rwjblue
Copy link
Member

rwjblue commented Aug 21, 2015

New should be used with all broccoli plugins. We are making this te default for all official plugins (and the vast majority of plugins work fine when used with new already).

@alanhogan
Copy link
Author

Fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants