Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Referene to a missing js file in the code #15

Closed
andrewminton opened this issue Mar 23, 2013 · 11 comments
Closed

Referene to a missing js file in the code #15

andrewminton opened this issue Mar 23, 2013 · 11 comments

Comments

@andrewminton
Copy link

There is a reference to a missing https://github.com/brockpetrie/dynamictextgroup/blob/development/fields/field.dynamictextgroup.php#L188

When you create a field all is good, When you edit a section with dynamictextgroup field the error in layout occurs. When I inspect element I noticed that a reference to the missing script came up.

@designermonkey
Copy link

Andrew, does this make the field unusable? I need this in a project.

@andrewminton
Copy link
Author

Yes mate, The presentation is all to pot in the Section entry editor.

I've searched Brocks code on all branches and there is no reference to this file in the repo.

@designermonkey
Copy link

Damn. Rethinking time then. Cheers Andrew.

andrewminton wrote:

Yes mate, The presentation is all to pot in the Section entry editor.


Reply to this email directly or view it on GitHub
#15 (comment).

@andrewminton
Copy link
Author

It may be a refactoring of what JS file is loaded at first build of section with dynamictextgroup and see what is in use there..

I got a feeling there is no need for that bit of code, cos it worked when I first created the section and started adding Dynamic Text Entry Fields.

@designermonkey
Copy link

Ok, when I get to that section, I'll take a look at it.

andrewminton wrote:

It may be a refactoring of what JS file is loaded at first build of
section with dynamictextgroup and see what is in use there..

I got a feeling there is no need for that bit of code, cos it worked
when I first created the section and started adding Dynamic Text Entry
Fields.


Reply to this email directly or view it on GitHub
#15 (comment).

@andrewminton
Copy link
Author

Tidy..

I'm in there too as well.. local build with 2.3.2 to test it out.. I am using the Development Branch and that's where I'm experiencing this issue.. I think Master branch is fine as it has no reference to the custom select2.custom.js file in there.

@designermonkey
Copy link

master isn't compatible with 2.3.x sadly.

I've run into other issues with the JS in this as it's only able to run a single instance of the field, and I haven't got time to rejig it to work for multiple, so have dropped it from the spec.

@andrewminton
Copy link
Author

Yeh, I think Multiple instances was on the TODO list for v3.

@andrewminton
Copy link
Author

A good duplicator to trump SSM is in dire need of some investment me
thinks.. so much promise.. Rowans Content
Fieldhttps://github.com/rowan-lewis/content_fieldis quite useful at
the moment.

On 26 March 2013 23:25, John Porter notifications@github.com wrote:

master isn't compatible with 2.3.x sadly.

I've run into other issues with the JS in this as it's only able to run a
single instance of the field, and I haven't got time to rejig it to work
for multiple, so have dropped it from the spec.


Reply to this email directly or view it on GitHubhttps://github.com//issues/15#issuecomment-15495365
.

@brockpetrie
Copy link
Owner

I've removed the line that references the missing file, so this should be fixed now. Thanks Andrew

@andrewminton
Copy link
Author

Ahh right, so it just wasn't needed then. Might file a small issue with styling looking all wonky when editing a section entry using develpoment branch.. will test first though.. cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants