Change default time to be today/15 weeks from today #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default was an arbitrary day, which was annoying. During the spring semesters the end date should be 16 weeks after the start date because of spring break in the middle. Who cares tho. I did not run tests locally because I don't know how to do that
|
I believe this solves issue #19 |
|
I think this solution is doable, but it is not a convenient way for user. Most of time we follow this config setting, which will just lead to the similar result like the previous setting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default was an arbitrary day, which was annoying. During the spring semesters the end date should be 16 weeks after the start date because of spring break in the middle. Who cares tho. I did not run tests locally because I don't know how to do that