Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest timer skipped when record edited during program #257

Open
ewencb opened this issue May 12, 2022 · 0 comments
Open

Rest timer skipped when record edited during program #257

ewencb opened this issue May 12, 2022 · 0 comments

Comments

@ewencb
Copy link

ewencb commented May 12, 2022

Hello, loving this app, thanks for all the hard work! Feel free to close this if it's intended behaviour but I thought I'd flag it since it wasn't what I expected.

Found in version:
0.20.5.1

Current behavior:
During a program session the rest timer doesn't start if the record is edited before marking as complete (eg. when increasing the weight on an exercise in a new session as part of progression). It works fine when editing after marking as complete, but typically I would choose a weight to increase to before starting the exercise.

Expected behavior:
Rest timer commences when record is marked as success or fail after editing.

Step to reproduce:
Start a program
Edit an exercise weight
Mark as success from editor pop-up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant