Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move description of substr2_ctl() #75

Closed
wants to merge 1 commit into from

Conversation

krlmlr
Copy link

@krlmlr krlmlr commented Dec 26, 2021

from "Details".

Perhaps substr2_ctl() should get its own help page instead?

@brodieG
Copy link
Owner

brodieG commented Dec 26, 2021

Thanks for the suggestion @krlmlr. I am very close to releasing 1.0 (release candidate is the rc branch), and in the process have been tweaking (and probably will further tweak) docs. Right now the doc in question looks like:

substr_ctl is a drop-in replacement for substr. Performance is slightly slower than substr, and more so for type = 'width'. CSI SGR sequences will be included in the substrings to reflect the format of the substring when it was embedded in the source string. substr2_ctl adds the ability to retrieve substrings based on display width in addition to the normal character width. substr2_ctl also provides the option to convert tabs to spaces with tabs_as_spaces prior to taking substrings.

So I think in reviewing I had a similar reaction to yours at some point. I did not know about the trick to create a multi-paragraph description, which is great.

I'm not sure about splitting the docs as I want people to realize substr2_ctl is there and that it does a lot more than the plain substr_ctl.

@brodieG
Copy link
Owner

brodieG commented Jan 10, 2022

v1.0 is out and includes documentation modifications that mostly address this (note, the modifications predate this PR). Thanks for noticing the issue and reaching out.

@brodieG brodieG closed this Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants