Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly check for numeric overflows #46

Closed
brodieG opened this issue Jul 8, 2017 · 1 comment
Closed

Properly check for numeric overflows #46

brodieG opened this issue Jul 8, 2017 · 1 comment
Labels
bug fixed in dev
Milestone
0.2.0

Comments

@brodieG
Copy link
Owner

brodieG commented Jul 8, 2017

Right now we check that numbers wrap, and although that works in theory we should really be checking against INT_MAX and the like since the wrapping is not defined behavior.
@brodieG brodieG added the bug label Jul 8, 2017
@brodieG brodieG added this to the 0.1.1 milestone Jul 8, 2017
brodieG added a commit that referenced this issue Jul 16, 2017
@brodieG
starting to address #46
a1da488
@brodieG
Copy link
Owner Author

brodieG commented Aug 19, 2017

Fixed most instances of this, there might be a couple floating around that have not been dealt with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed in dev
Projects
None yet
Milestone
0.2.0
Development

No branches or pull requests
1 participant
@brodieG