Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no log of generated example options unless enabled #257

Merged
merged 1 commit into from
Feb 26, 2020
Merged

no log of generated example options unless enabled #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,12 @@ const generateWithNormalizedOptions = ({
license: ${license}
view: ${view}
useAppleNetworking: ${useAppleNetworking}
` + (generateExample
? `
generateExample: ${generateExample}
exampleName: ${exampleName}
writeExamplePodfile: ${writeExamplePodfile}
`);
` : ``));

// QUICK LOCAL INJECTION overwite of existing execSync / commandSync call from
// mockable execa object for now (at least):
Expand Down
5 changes: 1 addition & 4 deletions ...gus-platforms/bogus-name/__snapshots__/cli-command-with-bogus-platforms-name.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@ Array [
license: MIT
view: false
useAppleNetworking: false
generateExample: false
exampleName: example
writeExamplePodfile: false
",
",
],
},
Object {
Expand Down
5 changes: 1 addition & 4 deletions ...platforms/empty-string/__snapshots__/cli-command-with-empty-platforms-string.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@ Array [
license: MIT
view: false
useAppleNetworking: false
generateExample: false
exampleName: example
writeExamplePodfile: false
",
",
],
},
Object {
Expand Down
11 changes: 4 additions & 7 deletions ...nc/with-logging/with-error/__snapshots__/cli-command-with-logging-with-error.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@ Array [
license: MIT
view: false
useAppleNetworking: false
generateExample: false
exampleName: example
writeExamplePodfile: false
",
",
],
},
Object {
Expand All @@ -48,9 +45,9 @@ Array [
"error": Array [
"Error: ENOPERM not permitted
at Object.ensureDir (.../tests/with-mocks/cli/command/func/with-logging/with-error/cli-command-with-logging-with-error.test.js:9:27)
at ensureDir (.../lib/lib.js:153:15)
at generateLibraryModule (.../lib/lib.js:279:10)
at generateWithNormalizedOptions (.../lib/lib.js:296:10)
at ensureDir (.../lib/lib.js:155:15)
at generateLibraryModule (.../lib/lib.js:281:10)
at generateWithNormalizedOptions (.../lib/lib.js:298:10)
at createLibraryModule (.../lib/cli-command.js:...
at Object.func (.../tests/with-mocks/cli/command/func/with-logging/with-error/cli-command-with-logging-with-error.test.js:62:9)
",
Expand Down
3 changes: 2 additions & 1 deletion ...e/with-logging/with-defaults/__snapshots__/create-with-example-with-defaults.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ Array [
license: MIT
view: false
useAppleNetworking: false

generateExample: true
exampleName: example
writeExamplePodfile: false
",
",
],
},
Object {
Expand Down
3 changes: 2 additions & 1 deletion ...e/with-example/with-logging/with-error/__snapshots__/with-yarn-error-logging.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ Array [
license: MIT
view: false
useAppleNetworking: false

generateExample: true
exampleName: example
writeExamplePodfile: false
",
",
],
},
Object {
Expand Down
3 changes: 2 additions & 1 deletion ...null-options/with-null-prefix/__snapshots__/create-with-example-with-options.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ Array [
license: MIT
view: false
useAppleNetworking: false

generateExample: true
exampleName: example
writeExamplePodfile: false
",
",
],
},
Object {
Expand Down
3 changes: 2 additions & 1 deletion ...ple/with-logging/with-options/__snapshots__/create-with-example-with-options.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@ Array [
license: ISC
view: false
useAppleNetworking: false

generateExample: true
exampleName: example
writeExamplePodfile: false
",
",
],
},
Object {
Expand Down