[DO NOT MERGE] Reproduce internal error in tsc

bin/glob-tsc.js

@@ -6,15 +6,21 @@ var spawn = require('cross-spawn'),
     commandArgs = options.unknown.concat(helper.resolveTSFiles()),
     proc = spawn(helper.getTSCCommand(), commandArgs, { stdio: 'inherit' });
 
-proc.on('exit', function (code, signal) {
+/**
+ * @param {number} code
+ * @param {number} signal
+ */
+function onExit (code, signal) {
     process.on('exit', function(){
         if (signal) {
             process.kill(process.pid, signal);
         } else {
             process.exit(code);
         }
     });
-});
+}
+
+proc.on('exit', onExit);
 
 // terminate children.
 process.on('SIGINT', function () {

lib/program-helper.js

@@ -20,11 +20,13 @@ function error() {
 
 /**
  * Resolve file globs based in command line or tsconfig.json file.
- * @returns {Array}
+ * May throw an error.
+ * @returns {string[]}
  */
 function resolveGlobs() {
     var options = Helper.getOptions(),
         tsConfigFile,
+        /** @type{string[]} */
         tsConfig;
 
     if (options['filesGlob'] && options['filesGlob'].length) {
@@ -41,14 +43,15 @@ function resolveGlobs() {
 
             return tsConfig['filesGlob'];
         } catch (err) {
-            error('tsconfig.json file is not accessible.', err);
+            // explicitly throw here to pass --strictNullChecks
+            throw error('tsconfig.json file is not accessible.', err);
         }
     }
 }
 
 /**
  * Check if a file exists
- * @param cmdPath
+ * @param {string} cmdPath
  * @returns {boolean}
  */
 function fileExists(cmdPath) {
@@ -80,9 +83,10 @@ Helper.getTSCCommand = function () {
 /**
  * Resolve ts file paths
  *
- * @returns {Array}
+ * @returns {string[]}
  */
 Helper.resolveTSFiles = function () {
+    /** @type{string[]} */
     var files = [];
 
     resolveGlobs().forEach(function (pattern) {
@@ -114,4 +118,7 @@ Helper.getOptions = function () {
     return commander;
 };
 
-module.exports = Helper;
+/**
+ * @typedef {object} Helper
+ */
+module.exports = Helper;

package.json

@@ -12,7 +12,7 @@
     "glob-tsc": "./bin/glob-tsc.js"
   },
   "scripts": {
-    "checkjs": "node bin/glob-tsc.js --allowJs --checkJs --noEmit --resolveJsonModule --target es5 -g bin/**/*.js,test/**/*.js",
+    "checkjs": "node bin/glob-tsc.js --allowJs --checkJs --noEmit --resolveJsonModule --target es5 --strictFunctionTypes --strictBindCallApply --noImplicitThis --strictNullChecks --noImplicitAny -g bin/**/*.js,test/**/*.js",
     "test": "npm-run-all checkjs test:mocha",
     "test:mocha": "mocha --timeout 5000",
     "test:watch": "_mocha --watch"
@@ -28,7 +28,11 @@
   },
   "license": "ISC",
   "devDependencies": {
+    "@types/chai": "^4.2.4",
+    "@types/cross-spawn": "^6.0.1",
+    "@types/glob": "^7.1.1",
     "@types/mocha": "^5.2.7",
+    "@types/mock-require": "^2.0.0",
     "@types/node": "^12.11.7",
     "chai": "^4.2.0",
     "mocha": "^6.2.2",

test/cross-spawn.mock.js

@@ -1,14 +1,28 @@
 var expect = require('chai').expect;
 
+/**
+ * @constructor
+ */
 var Process = function () {
+    /** @type {Record<string, Function>} */
     var listeners = {};
 
-    this.on = function (event, cb) {
+    /**
+     * @param {string} event
+     * @param {Function} cb
+     */
+    function onEvent (event, cb) {
         listeners[event] = cb;
     };
+
+    this.on = onEvent;
 };
 
 module.exports =
+    /**
+     * @param {string} cmd
+     * @param {string[]} args
+     */
     function (cmd, args) {
         expect(cmd).to.equal('tsc');
         expect(args).to.eql(['src/User.ts']);