-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): updates and adds support for rollup v3 #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies for the delay, I think we need to add CI testing with Rollup v2 as well.
Maybe the best thing would be to check the output sizes less precisely with Rollup v2. To do this in CI, I would recommend an approach like this:
- add CI task that adds specific npm or Yarn installation of Rollup v2, test with an environmental variable defined if using Rollup v2
- then test some sizes less precisely or consider other adjustments in case of Rollup v2
As an alternative: we could also drop support for Rollup v2 in a new 0.x release of this Rollup plugin. I think this could be an acceptable alternative if we document it somewhere as this fork does not seem to have too many users.
Thanks for your contribution, definitely much appreciated!
@brodybits thanks for taking a look! Do you anticipate new/changing features that would make backwards compatibility on Rollup v2 beneficial? If not, bumping to a new minor and dropping v2 support works for me. In that case, I can update the README. Give it some thought, I'm cool making changes in either direction. 👍🏻 |
as discussed in PR brodybits#25
Sounds good, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved & merging with removal of Rollup v2 support, as already discussed, thanks!
I think this should be a somewhat simple PR but let me know if there are additional things I should test for... the existing plugins seem to hold up.
Addresses #24