Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmbedEverything plugin does not work for Instagram #15

Closed
zairja opened this issue Dec 18, 2020 · 3 comments
Closed

EmbedEverything plugin does not work for Instagram #15

zairja opened this issue Dec 18, 2020 · 3 comments

Comments

@zairja
Copy link
Contributor

zairja commented Dec 18, 2020

Describe the bug
Putting an Instagram URL on its own line in markdown does not embed it.

To Reproduce
Steps to reproduce the behavior:

  1. Paste the URL into the markdown file.
  2. The URL is rendered as a link instead of an embedded image/link.

Expected behavior
The current markdown rendering seems to take any URL (even if the http / www is omitted) and wrap it in an <a> tag whereas embed-everything requires the Instagram URL to be by itself wrapped in <p> tags. It may not be something that can be fixed / tweaked if it's core to 11ty.

@broeker
Copy link
Owner

broeker commented Dec 19, 2020

@zairja interesting, I had not tested Instagram but on my local copy it seems to be working okay:

https://www.instagram.com/p/Btg1jd_HJsT/

Inserting that on its own line resulted in the attached screenshot. I'll leave this open pending further details.

insta

@broeker
Copy link
Owner

broeker commented Dec 19, 2020

I do notice a small delay where it renders a small gray bar before rendering the insta post, but not sure I'll have any control over that. I also fixed the CSS to make sure Insta embeds are centered like other images/embeds.

@zairja
Copy link
Contributor Author

zairja commented Dec 19, 2020

I somehow borked a fork. Unable to trace down where the issue cropped up. Confirmed it works fine with latest changes in spacebook repo.

sidenote: unfortunately deploying directly to netlify (letting it create the github repo) doesn't flag created repos as forks making it difficult to merge in upstream changes 😢. going forward, I'll fork then connect the repo to netlify.

@zairja zairja closed this as completed Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants