This repository has been archived by the owner on Dec 26, 2021. It is now read-only.
Devel #5
Merged
Devel #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 14, 2017 20:36
LICENCE.md
Outdated
|
|
||
| Version 3, 19 November 2007 | ||
| Copyright 2009 Twitter, Inc. |
There was a problem hiding this comment.
lol bad copy past ;/
src/core/bot.ts
Outdated
| // it's an integration | ||
| if (instance.listen) { | ||
| this.logger.info({ method: 'use', message: `Integration: ${instance.serviceName()}` }); | ||
| this.addIntegration(instance); | ||
| } else if (instance.receive || instance.send) { // Middleware | ||
| if (instance.receive) { | ||
| } else if (instance.incoming || instance.outgoing) { // Middleware |
There was a problem hiding this comment.
Could drop these as you do it again right after.
There was a problem hiding this comment.
Something like this, does it make sense?
public use(instance: any, filter?: string | string[]): void {
// it's an integration
if (instance.listen) {
this.logger.info({ method: 'use', message: `Integration: ${instance.serviceName()}` });
this.addIntegration(instance);
} else if(instance.incoming) {
this.logger
.info({ method: 'use', message: `incoming middleware: ${instance.serviceName()}` });
this.incomingMiddlewares.push({
name: `${instance.serviceName()}.incoming`,
middleware: instance,
filter: filter || null,
});
} else if (instance.outgoing) { // Middleware
this.logger
.info({ method: 'use', message: `outgoing middleware: ${instance.serviceName()}` });
this.outgoingMiddlewares.push({
name: `${instance.serviceName()}.outgoing`,
middleware: instance,
filter: filter || null,
});
}
return;
}| } from './interfaces'; | ||
|
|
||
| const isObservable = (obs:any): boolean => obs && typeof obs.subscribe === 'function'; | ||
| const isPromise = (obj:any): boolean => |
There was a problem hiding this comment.
Does obj instanceof Promise not work?
There was a problem hiding this comment.
yes is not work, weird...
dustinblackman
approved these changes
Apr 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.