-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opencap alias support #17
Conversation
I not sure if it should be inside I think this
Something like a
If At least for me it's more easy to understand what is doing on, if it's already a valid address it is used as a I'm testing it right now. |
Should we add KeyPinning for already-know OpenCAP severs? In the past, when uses a server (instead of connect to the nodes). So, the wallet have a hardcoded public-key, it prevents a MITM when the client trust in some insecure certificate authorities. In this case it was set in: Nanollet/RPC/Connectivity/socket.go Line 30 in 5de0895
Then it's used in the Nanollet/RPC/Connectivity/socket.go Lines 48 to 52 in 5de0895
I think should possible to do a Key Pinning using the |
I don't think we can do anything for "known opencap servers" because the point of OpenCAP is to be an opencap protocol and allow anyone to run a server. Ogdolo just happens to be the only one running now because its a new protocol. In the future there will hopefully be more servers than we can count! |
LookupAlias returns the string representation of a Nano address and an error, I can change that though |
I working on it right now. 👍 |
Cool, I'll just let you refactor. If need any input let me know |
Also, if you have any generic OpenCAP questions, we are available in our discord server: https://discord.gg/FTMCBE8 |
I added support for OpenCAP aliases. I tested to make sure the addresses are pulled in correctly. Obviously I raised an issue where my wallet isn't creating a receive block but that shouldn't change this PR.
I'm not sure if I messed up how you wanted to organize your code or not, let me know.
I think those generated files should NOT be in the repo. I was talking about the files below that should be in the repo:
In order to test, make an alias at https://ogdolo.com